Re: [Gnash-dev] [COMMITTED] inclusion of ffmpeg patch into Gnash 0.8.2 ?

[Russ Nelson]

strk writes:
 > Next thing to look at (in head) would be proper abstractions to
 > reduce (ideally drop) ifdefs around and duplication of common code.

Yes, ifdefs are the WRONG way to do configuration.  The right way is
to have a set of functions which get implemented by two derived
classes.  Then it's just a question of selecting the correct class to
link into your code if at compile time, or instantiate if at runtime.

#ifdef EVIL
#  assert "yes!"
#endif

-- 
--my blog is at    http://blog.russnelson.com   | Software that needs
Crynwr sells support for free software  | PGPok | documentation is software
521 Pleasant Valley Rd. | +1 315-323-1241       | that needs repair.
Potsdam, NY 13676-3213  |     Sheepdog          |