|
From: | Bastiaan Jacques |
Subject: | Re: [Gnash-dev] Re: sound_handler.h |
Date: | Thu, 30 Oct 2008 08:19:47 -0700 (PDT) |
User-agent: | Alpine 1.00 (DEB 882 2007-12-20) |
On Thu, 30 Oct 2008, Klaus Rechert wrote:
Hi,I do not understand why to use int32_t / int16_t types for the output sink. Makes everything complicated (IMHO).The only difference is that instead of fetching 32bit numebrs we fetch 16bit ones and require to fetch in couples. h, so you suggest we refer to "sample pairs" when we count them ? Should the interface be something like this then: void fetchSamples(boost::int32_t* to, unsigned int nSamples)=0; If so, isn't thre a need to specify byte orders for those 32bit numbers ?I'd use (uint8_t *) as "raw data".
I don't understand where the 32-bit number comes from. The numbers are actually 16-bit, so we should use int16_t. If it is believed that an array of 16-bit values actually representing an intereleaved array of left-and-right stereo samples is confusing, than we should use an array of struct StereoSample { int16_t left, int16_t right };. Bastiaan
[Prev in Thread] | Current Thread | [Next in Thread] |