Re: [Gnash-dev] Gst media parser warning may be hiding bug

[strk]

If I recall correctly we did drop the need for probe
a long time ago.
You should be able to move the '#if 0' from line 86
to line 74 with no problem (untested).

--strk;

On Sun, Aug 08, 2010 at 03:22:27PM -0700, John Gilmore wrote:
> GCC complained (many times) while building, but this warning on this
> function seemed like an issue to me:
> 
> gst/MediaParserGst.cpp:257: warning: comparison of unsigned expression >= 0 
> is always true
> 
> /// The idea here is that probingConditionsMet will return false, unless:
> /// a) all data types in the stream were found.
> /// b) The timer (currently for 1 second) has expired, if and only if we
> ///    succeeded in pushing MIN_PROBE_SIZE bytes into the bin. This should
> ///    protect low-bandwidth cases from stopping the probe early.
> 
> bool MediaParserGst::probingConditionsMet(const SimpleTimer& timer)
> {
>     return foundAllStreams() || (timer.expired() && getBytesLoaded() >= 
> MIN_PROBE_SIZE);
> }
> 
> MIN_PROBE_SIZE is set to zero near a commented out section:
> 
> #define PUSHBUF_SIZE 1024
> //#define MIN_PROBE_SIZE (PUSHBUF_SIZE * 3)
> #define MIN_PROBE_SIZE 0
> 
> This function appears to be the only place that MIN_PROBE_SIZE is used.
> So, the function devolves to:
> 
>     return foundAllStreams() || timer.expired();
> 
> Is that what the code should be doing?
> 
>       John
> 
> _______________________________________________
> Gnash-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-dev

-- 

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html