Re: [Gnash-dev] Patch: fix gnash being unable to download anything with newer libcurl versions

[Hans de Goede]

Hi,

On 10/03/2010 09:16 PM, Rob Savoye wrote:
> On 08/27/2010 02:56 AM, Hans de Goede wrote:
>
> > So I did some debugging and found at that there is a bad interaction
> > between gnash and the latest libcurl, the attached
> > gnash-0.8.8-new-libcurl.patch fixes this.
> >
> > The problem is that newer libcurl versions (atleast 7.21.x) return -1
> > for maxfd from curl_multi_fdset while they are doing dns resolving. This
> > gets combined with a short (7ms) return value from curl_multi_timeout
> > indicating that the thread / caller should just sleep a bit and then retry.
>
>    I fixed this a better way, as we do want to check the value of max_fd
> for problems. I filed an official bug report on this for Gnash, which
> contains my latest patch: https://savannah.gnu.org/bugs/?31235. With
> this patch, Gnash works with the very latest libcurl as well as the
> older one. Please test attached the patch, if it's good for you, I'll
> check it in.

I can confirm the new patch fixes this as well. Also I believe that
this patch:
http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=c6116b3f7eb2d657141a55afa66d573fd1cda7af

Fixes the problem of select never returning except on timeout which
I also was seeing.

Regards,

Hans