gnash-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-dev] [patch] Get rid of warning in klash_part.cpp


From: Petter Reinholdtsen
Subject: [Gnash-dev] [patch] Get rid of warning in klash_part.cpp
Date: Tue, 23 Nov 2010 10:20:00 +0100
User-agent: Mutt/1.5.19 (2009-01-05)

Yet another patch to get rid of a compile warning.  This time it is
this one:

  klash_part.cpp:471: warning: comparison between signed and unsigned
    integer expressions

The code in question look like this:

     for (unsigned int i = 0; i < args.size (); ++i) {
         kdDebug () << "      " << args[i] << endl;
     }

The problem is that QStringList::size() return int, not unsigned it,
according to <URL:http://doc.qt.nokia.com/4.6/qlist.html#size>.  The
fix is to use int instead of unsigned int for i.

diff --git a/plugin/klash4/klash_part.cpp b/plugin/klash4/klash_part.cpp
index 1c413cd..5b970db 100644
--- a/plugin/klash4/klash_part.cpp
+++ b/plugin/klash4/klash_part.cpp
@@ -468,7 +468,7 @@ KDE_NO_EXPORT bool KlashLiveConnectExtension::call
     if (!entry)
         return false;
     kdDebug () << "entry " << entry->name << endl;
-    for (unsigned int i = 0; i < args.size (); ++i) {
+    for (int i = 0; i < args.size (); ++i) {
         kdDebug () << "      " << args[i] << endl;
     }
     //Klash::View * view = static_cast <Klash::View*> (player->widget ());

Happy hacking,
-- 
Petter Reinholdtsen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]