Re: [Gnash-dev] NetConnection And NetStream

[Sandro Santilli]

On Wed, Feb 20, 2013 at 08:48:47PM +0530, George Thomas wrote:
> On Wed, Feb 20, 2013 at 1:22 AM, Sandro Santilli <address@hidden> wrote:
> 
> > On Wed, Feb 20, 2013 at 12:07:25AM +0530, George Thomas wrote:
> > > Hi,
> > >
> > > The TODO list in Gnash specifies partially implemented NetConnection and
> > > NetStream classes in Gnash.
> > > I understood these classes to be the NetConnection and NetStream classes
> > in
> > > (libcore/asobj)
> > >
> > > Could someone let me know what is to be done to get these classes
> > complete.
> >
> > You can see NetConnection.as and NetStream.as in
> > testsuite/actionscript.all/
> > Known failures are encoded with xcheck and xcheck_equals.
> > If you handle to fix the code you'll get XPASS lines when you run
> > the resulting *.swf files with gprocessor or gnash -v.
> >
> >
> xcheck and xcheck_equals are absent in NetConnection.as
> Does this mean NetConnection is complete ?

It probably means the file needs more tests :)

> Found only a line  with xfail in this. Is this ok to be a failure or should
> this be fixed ?
> 
> // test the NetConnection::connect method
> 
> if ( ! tmp.connect("rtmp://
> www.mediacollege.com/flash/media-player/testclip-4sec.flv") )
> 
> {
>         // FIXME: this would fail in the reference player too...
> 
>         xfail("NetConnection::connect() didn't initialize correctly");

I think that failure is due to cross-domain configuration.
If you know of a way to make that succeed with the proprietary player
it'll be worth updating the testcase. We should NOT expect to behave
in a different way from the reference player.

In any case note that RTMP support is NOT implemented in Gnash.
It's not minor work, but you're welcome if you want to give it a try.

> I was able to find a lot of opportunities (xchecks) in NetStream.as

I think it's easier to start there.

> Should the additional test cases be added based on docs specified for as2 ?
> http://docs.brajeshwar.com/as2/NetConnection.html
> Or should it based on the rtmp specification document ?

All tests should be based on reverse-engeneering the proprietary player.
Start from any doc you want, but always check with the official player.
Most developers code/test to the player, not to the specs.
Leave a comment in the test if the proprietary player behaves differently
than the specs (it happens a lot) and we can discuss what to do on a
case-by-case basis (sometimes the proprietary player just crash, we don't
want to follow it there...)

--strk; 

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html