gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Missing arg for PackBlock in nk6510.c


From: Pawel Kot
Subject: Re: [Patch] Missing arg for PackBlock in nk6510.c
Date: Wed, 4 Feb 2004 14:47:19 +0100 (CET)

On Wed, 4 Feb 2004, Reiner Steib wrote:

> On Fri, Jan 30 2004, Pawel Kot wrote:
>
> > On Fri, 30 Jan 2004, Reiner Steib wrote:
> >
> >> in the current CVS version, common/phones/nk6510.c didn't compile.
> >> The attached patch fixes this.  I'm not sure if it's the correct way
> >> to fix the problem, so please check.
> >
> > Correct. My fault, sorry. Commited into cvs.
>
> Thanks.  Was it intended that you changed the second argument for
> PackBlock from "j * 2 + 6" to "j * 2 + 5"?

Yes, I looked over the function and saw j * 2 + 5 is used everywhere. "+
6" is used in nk7110 driver. If it needs changing, it should be replaced
in all occurences.

pkot
-- 
mailto:address@hidden
http://www.gnokii.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]