Re: [Gnu-arch-users] Re: Patch : precomimt hook

[Erik de Castro Lopo]

On Sat, 4 Oct 2003 16:07:15 -0800
Ethan Benson <address@hidden> wrote:

> oh really, why not explain why instead of being an asshole.

Ethan, you really do seem to have the wrong end of the stick. Its
obvious that you haven't looked at my patch.

Please look again. It adds 8 lines of code and removes 2; one of
the added lines is a comment and two are open and close braces. 

Its really, really difficult to produce what you call "a hodge podge 
of hacks implementing foocmd-hook, barcmd-hook blah blah" with a 
patch of 3 lines of code.

The proposed patch, calls the existing hook framework which ends
up calling the ~/.arch-params/hook with $1 set to "precommit" where
it would otherwise be called with "commit", "import" or any of
the other existing hooks.

Please accept that you were wrong and move on.

Erik
-- 
+-----------------------------------------------------------+
  Erik de Castro Lopo  address@hidden (Yes it's valid)
+-----------------------------------------------------------+
"And MS thinks Linux is vulnerable to forking? 95, 95 OEM SR2, 98, 98SE,
ME, NT, 2000, Bob, .NET, CE, Datacenter, Server, Adv. Server, and now
Web Server, sheesh." -- BTS on LinuxToday.com