gnuastro-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnuastro-commits] master f0d20593: Table: variable initialized to avoid


From: Mohammad Akhlaghi
Subject: [gnuastro-commits] master f0d20593: Table: variable initialized to avoid compiler warning
Date: Sat, 8 Jan 2022 11:51:01 -0500 (EST)

branch: master
commit f0d2059324d32e4a82feffd30e9743fceec96827
Author: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>

    Table: variable initialized to avoid compiler warning
    
    Until now, the newly added 'table_catrows_findhdu' function to Gnuastro's
    Table program would print an "variable may be used un-initialized" warning
    during compilation on some compilers (I noticed while test-packaging for
    Debian).
    
    With this commit, the respective variable is now initialized to NULL.
    
    Also, I added an item in the packaging checklist to not forget to update
    the copyright years.
---
 bin/table/table.c         | 3 +--
 doc/release-checklist.txt | 4 ++++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/bin/table/table.c b/bin/table/table.c
index fb55fa60..6ce68a0f 100644
--- a/bin/table/table.c
+++ b/bin/table/table.c
@@ -825,7 +825,7 @@ table_catcolumn(struct tableparams *p)
 static char *
 table_catrows_findhdu(char *filename, gal_list_str_t **hdull)
 {
-  char *hdu;
+  char *hdu=NULL;
 
   /* Set the HDU (not necessary for non-FITS tables). */
   if(gal_fits_file_recognized(filename))
@@ -837,7 +837,6 @@ table_catrows_findhdu(char *filename, gal_list_str_t 
**hdull)
               "A call to '--catrowhdu' is necessary to identify "
               "its HDU/extension");
     }
-  else hdu=NULL;
 
   /* Return the HDU. */
   return hdu;
diff --git a/doc/release-checklist.txt b/doc/release-checklist.txt
index d3014001..48373e7c 100644
--- a/doc/release-checklist.txt
+++ b/doc/release-checklist.txt
@@ -373,6 +373,10 @@ Steps necessary to Package Gnuastro for Debian.
 
      $ emacs debian/control   # Only three digits "X.Y.Z"
 
+ - Check if the years in 'debian/copyright' are up to date (usually on
+   first packaging after a new year):
+
+     $ emacs debian/copyright
 
  - If the soname of the shared libraries has changed:
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]