gnuastro-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnuastro-commits] master f934acb0: MakeCatalog: no warning of small --u


From: Mohammad Akhlaghi
Subject: [gnuastro-commits] master f934acb0: MakeCatalog: no warning of small --upnum when --quiet is called
Date: Thu, 20 Apr 2023 08:12:53 -0400 (EDT)

branch: master
commit f934acb00ada48e703d5aa2e25767e22ea1bf5fe
Author: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>

    MakeCatalog: no warning of small --upnum when --quiet is called
    
    Until now, the warning message for a small value to '--upnum' in
    MakeCatalog would not be suppressed when the '--quiet' option was called!
    Even though, the message clearly stated that it will not be printed if
    called with '--quiet'.
    
    With this commit, a check for the calling of '--quiet' has been added
    before the warning message is printed.
    
    This bug was reported by Teet Kuutma.
    
    This fixes bug #64076.
---
 NEWS               | 2 ++
 bin/mkcatalog/ui.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index 2e7be7a5..38c42a72 100644
--- a/NEWS
+++ b/NEWS
@@ -379,6 +379,8 @@ See the end of the file for license conditions.
               Reported by Faezeh Bidjarchian.
   bug #63969: make distcheck error due to temporary files of
               astscript-psf-select-stars. Reported by Siyang He.
+  bug #64076: MakeCatalog prints --upnum warning even with
+              --quiet. Reported by Teet Kuutma.
 
 
 
diff --git a/bin/mkcatalog/ui.c b/bin/mkcatalog/ui.c
index dbba00dc..caacf661 100644
--- a/bin/mkcatalog/ui.c
+++ b/bin/mkcatalog/ui.c
@@ -1745,7 +1745,7 @@ ui_preparations_upperlimit(struct mkcatalogparams *p)
     }
 
   /* Check the number of random samples. */
-  if( p->upnum < MKCATALOG_UPPERLIMIT_MINIMUM_NUM )
+  if( p->upnum < MKCATALOG_UPPERLIMIT_MINIMUM_NUM && p->cp.quiet==0 )
     error(EXIT_SUCCESS, 0, "WARNING: %zu (value given to '--upnum') will "
           "produce unreliable upper-limit measurements. This warning will "
           "be printed for '--upnum' values less than %d. You can suppress "



reply via email to

[Prev in Thread] Current Thread [Next in Thread]