[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnuastro-commits] master b0a01792: Configuration: Python extensions hav
From: |
Mohammad Akhlaghi |
Subject: |
[gnuastro-commits] master b0a01792: Configuration: Python extensions have to be manually activated |
Date: |
Tue, 25 Apr 2023 15:07:58 -0400 (EDT) |
branch: master
commit b0a01792fad9d104d6b424c973932643dcd0d90e
Author: Labeeb Asari <asari.r.labeeb7@gmail.com>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Configuration: Python extensions have to be manually activated
Until now, the '--with-python' configure option had described itself as
"enable support for python" (which is contradictory to the option
name!). Also, when it was given, a "no" was given to the "with_python"
variable (which is again contradictory!). A third contradiction came when
we checked for its value: we would only attempt to do the Python checks
when 'with_python' was 'no'!
So in the end from the user's perspective, only the documentation of this
option was wrong, not its operation (the Python checks would only occur
when '--with-python' was given).
With this commit, these contradictions have been addressed: the description
has been corrected and the variables are now given a value of 'yes'.
---
configure.ac | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index 400f9752..702fd691 100644
--- a/configure.ac
+++ b/configure.ac
@@ -286,6 +286,7 @@ AC_MSG_RESULT( $path_warning )
has_gsl=yes
has_libgit2=1
has_cmath=yes
+with_python=no
has_wcslib=yes
has_cfitsio=yes
has_libtiff=yes
@@ -768,9 +769,9 @@ AS_IF([test "x$has_topcat" = "xno"], [anywarnings=yes])
# all the following checks in the venv.
AC_ARG_WITH([python],
[AS_HELP_STRING([--with-python],
- [disable support for python])],
- [], [with_python=no])
-AS_IF([test "x$with_python" != xno],
+ [enable support for python])],
+ [with_python=yes], [])
+AS_IF([test "x$with_python" == xyes],
[
# Variables to simplify commands below.
py_check_cmd='from sysconfig import get_paths; \
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [gnuastro-commits] master b0a01792: Configuration: Python extensions have to be manually activated,
Mohammad Akhlaghi <=