[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnuastro-commits] master c0a50956: MakeCatalog: correct command in sugg
From: |
Mohammad Akhlaghi |
Subject: |
[gnuastro-commits] master c0a50956: MakeCatalog: correct command in suggested statement of error message |
Date: |
Tue, 27 Feb 2024 10:44:12 -0500 (EST) |
branch: master
commit c0a509569c46715dce43a3ed272769aaa2617403
Author: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>
MakeCatalog: correct command in suggested statement of error message
Until now, when MakeCatalog was given a labels image with negative values,
it would suggest an Arithmetic command to correct the input in case the
input was from a clumps image. However, the command had an extra 'i' in it;
causing the Arithmetic command to produce an error.
With this commit, the suggested command has been amended to remove any 'i's
(which were redundant for this suggestion; but necessary in the previous
proposed command).
This bug was reported by Zahra Sharbaf.
This fixes bug #65377.
---
NEWS | 4 ++++
bin/mkcatalog/ui.c | 2 +-
doc/announce-acknowledge.txt | 1 +
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 6ba23390..a21fb5ff 100644
--- a/NEWS
+++ b/NEWS
@@ -127,6 +127,10 @@ See the end of the file for license conditions.
a coma as the decimal point on some operating systems. Reported by
Jesús Vega and fixed by Raul Infante-Sainz.
+ - bug #65377: MakeCatalog's suggested command when labeled image has
+ negative values (and MakeCatalog crashes) is wrong. Reported by Zahra
+ Sharbaf.
+
diff --git a/bin/mkcatalog/ui.c b/bin/mkcatalog/ui.c
index 7fda4c96..f6517ccb 100644
--- a/bin/mkcatalog/ui.c
+++ b/bin/mkcatalog/ui.c
@@ -773,7 +773,7 @@ ui_one_tile_per_object_correct_numobjects(struct
mkcatalogparams *p)
"0 where'. For this scenario, a better solution is to "
"only keep the clumps and give them each a separate "
"label with a command like this: 'astarithmetic file.fits "
- "-hCLUMPS set-i i i 0 gt 2 connected-components'");
+ "-hCLUMPS 0 gt 2 connected-components'");
/* We are on an object. */
if(*l>0)
diff --git a/doc/announce-acknowledge.txt b/doc/announce-acknowledge.txt
index 4d933524..25216c7f 100644
--- a/doc/announce-acknowledge.txt
+++ b/doc/announce-acknowledge.txt
@@ -8,6 +8,7 @@ Juan Castillo Ramírez
Phil Wyett
Rahna Payyasseri Thanduparackal
Raul Infante-Sainz
+Zahra Sharbaf
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [gnuastro-commits] master c0a50956: MakeCatalog: correct command in suggested statement of error message,
Mohammad Akhlaghi <=