gnuastro-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnuastro-commits] master 2da78ae8: astscript-radial-profile: removed ba


From: Mohammad Akhlaghi
Subject: [gnuastro-commits] master 2da78ae8: astscript-radial-profile: removed bash-specific redirection
Date: Sat, 27 Jul 2024 12:04:34 -0400 (EDT)

branch: master
commit 2da78ae8ac7b71a8592c9d8e168bb3d2dfde9872
Author: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>

    astscript-radial-profile: removed bash-specific redirection
    
    Until now, the radial profile script used the '&>' construct to re-direct
    standard and error strings to '/dev/null'. However, this way of redirecting
    is specific to Bash and may not work on other shells.
    
    With this commit, the problem is fixed by replacing it with this command:
    '> /dev/null 2>&1'.
    
    This problem was reported by Phil Wyett, from the output of Debian's
    Lintian.
---
 bin/script/radial-profile.sh | 2 +-
 doc/announce-acknowledge.txt | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/bin/script/radial-profile.sh b/bin/script/radial-profile.sh
index 185e15c9..7ffe95ba 100755
--- a/bin/script/radial-profile.sh
+++ b/bin/script/radial-profile.sh
@@ -1081,7 +1081,7 @@ if [ x$polar = x1 ]; then
 
     # If the output is a FITS file, then add a new HDU. Otherwise (for
     # example output is plain-text), we need to make a new file.
-    if astfits $outputraw &> /dev/null; then
+    if astfits $outputraw > /dev/null 2>&1; then
         exthdu=2
         polarfile=$outputraw
     else
diff --git a/doc/announce-acknowledge.txt b/doc/announce-acknowledge.txt
index 537e971d..41dff5b6 100644
--- a/doc/announce-acknowledge.txt
+++ b/doc/announce-acknowledge.txt
@@ -2,6 +2,7 @@ Alphabetically ordered list to acknowledge in the next release.
 
 Antonio Diaz Diaz
 Hok Kan (Ronald) Tsang
+Phil Wyett
 
 
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]