[gnuastro-commits] master a2ba97b9: Library (fits.h): better grammar in keyword comments with versions

[Mohammad Akhlaghi]

branch: master
commit a2ba97b976df4b80fc4484fef55677056b61a23b
Author: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>

    Library (fits.h): better grammar in keyword comments with versions
    
    Until now, the comments of the FITS keywords that report the version of
    Gnuastro's dependencies and Gnuastro itself was in the format of "Version
    of AAAAA used." (where 'AAAAA' is the name of the software). But this way
    of using 'used' makes it feel like a second-hand GSL for example!!!
    
    With this commit, the the 'used' has been moved to after the software name
    to properly convey the meaning.
    
    This problem was reported by Joseph Putko.
---
 doc/announce-acknowledge.txt | 1 +
 lib/fits.c                   | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/doc/announce-acknowledge.txt b/doc/announce-acknowledge.txt
index e52ee67e..48eb016a 100644
--- a/doc/announce-acknowledge.txt
+++ b/doc/announce-acknowledge.txt
@@ -5,6 +5,7 @@ Alejandro Lumbreras-Calle
 Antonio Diaz Diaz
 Carlos Marrero de La Rosa
 Hok Kan (Ronald) Tsang
+Joseph Putko
 Phil Wyett
 Ole Streicher
 Rahna Payyasseri Thanduparackal
diff --git a/lib/fits.c b/lib/fits.c
index 87d59c77..b4577714 100644
--- a/lib/fits.c
+++ b/lib/fits.c
@@ -1738,7 +1738,7 @@ 
gal_fits_key_list_add_software_versions(gal_fits_list_key_t **keylist)
     error(EXIT_FAILURE, 0, "%s: asprintf allocation", __func__);
 #endif
   gal_checkset_allocate_copy("CFITSIO", &kname);
-  gal_checkset_allocate_copy("Version of used CFITSIO.", &comment);
+  gal_checkset_allocate_copy("Version of CFITSIO used.", &comment);
   gal_fits_key_list_add(keylist, GAL_TYPE_STRING, kname, 1,
                         cfitsioversion, 1, comment, 1, NULL, 0);
 
@@ -1750,7 +1750,7 @@ 
gal_fits_key_list_add_software_versions(gal_fits_list_key_t **keylist)
   wcslibversion_const=wcslib_version(wcslibvers);
   gal_checkset_allocate_copy(wcslibversion_const, &wcslibversion);
   gal_checkset_allocate_copy("WCSLIB", &kname);
-  gal_checkset_allocate_copy("Version of used WCSLIB.", &comment);
+  gal_checkset_allocate_copy("Version of WCSLIB used.", &comment);
   gal_fits_key_list_add(keylist, GAL_TYPE_STRING, kname, 1,
                         wcslibversion, 1, comment, 1, NULL, 0);
 #endif
@@ -1758,7 +1758,7 @@ 
gal_fits_key_list_add_software_versions(gal_fits_list_key_t **keylist)
   /* Write the GSL version. */
   gal_checkset_allocate_copy("GSL", &kname);
   gal_checkset_allocate_copy(GSL_VERSION, &gslversion);
-  gal_checkset_allocate_copy("Version of used GNU Scientific Library.",
+  gal_checkset_allocate_copy("Version of GNU Scientific Library used.",
                              &comment);
   gal_fits_key_list_add(keylist, GAL_TYPE_STRING, kname, 1,
                         gslversion, 1, comment, 1, NULL, 0);
@@ -1766,7 +1766,7 @@ 
gal_fits_key_list_add_software_versions(gal_fits_list_key_t **keylist)
   /* Write the Gnuastro's version. */
   gal_checkset_allocate_copy("GNUASTRO", &kname);
   gal_checkset_allocate_copy(PACKAGE_VERSION, &gnuastroversion);
-  gal_checkset_allocate_copy("Version of used GNU Astronomy Utilities.",
+  gal_checkset_allocate_copy("Version of GNU Astronomy Utilities used.",
                              &comment);
   gal_fits_key_list_add(keylist, GAL_TYPE_STRING, kname, 1,
                         gnuastroversion, 1, comment, 1, NULL, 0);