gnuastro-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnuastro-commits] master bc3ac513 2/2: astscript-color-faint-gray: The


From: Mohammad Akhlaghi
Subject: [gnuastro-commits] master bc3ac513 2/2: astscript-color-faint-gray: The output of astmkprof was not set correctly
Date: Tue, 1 Oct 2024 20:17:54 -0400 (EDT)

branch: master
commit bc3ac513b1a4cef543ae7a2083c45a6bd47bc183
Author: Samane Raji <samaneraji@gmail.com>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>

    astscript-color-faint-gray: The output of astmkprof was not set correctly
    
    Until now, if we wanted to use a kernel and convolve the background, we
    make a gussian kernel with astmkprof. But the output of the command was not
    correct and it could not save the kernel.
    
    With this commit, the correct variable was used for the output name. The
    solution was also verified by Raul Infante-Sainz.
    
    This fixes bug #66262.
---
 NEWS                           | 3 +++
 bin/script/color-faint-gray.sh | 2 +-
 doc/announce-acknowledge.txt   | 1 +
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index 0f1337e2..3dd7df92 100644
--- a/NEWS
+++ b/NEWS
@@ -39,6 +39,9 @@ See the end of the file for license conditions.
     (smaller than a pixel even after accounting for the truncation
     factor). Reported by Alejandro Camazón Pinilla.
 
+  - bug #66262: color-faint-gray crashes when using --graykernelfwhm. Found
+    and fixed by Samane Raji.
+
   - bug #66280: Convolve's check images not in same directory as output.
 
 
diff --git a/bin/script/color-faint-gray.sh b/bin/script/color-faint-gray.sh
index 04ea0c40..e4e198d4 100644
--- a/bin/script/color-faint-gray.sh
+++ b/bin/script/color-faint-gray.sh
@@ -888,7 +888,7 @@ else
         else
           i_back_kernel="$tmpdir/back_kernel.fits"
           astmkprof --kernel=gaussian,$graykernelfwhm,3 \
-                    --oversample=1 --output=$i_gray_kernel $quiet
+                    --oversample=1 --output=$i_back_kernel $quiet
           astconvolve $i_back --hdu=$khdu --kernel=$i_back_kernel \
                       --domain=spatial --output=$i_back_convolved $quiet
         fi
diff --git a/doc/announce-acknowledge.txt b/doc/announce-acknowledge.txt
index 48eb016a..3f3bd9d9 100644
--- a/doc/announce-acknowledge.txt
+++ b/doc/announce-acknowledge.txt
@@ -7,6 +7,7 @@ Carlos Marrero de La Rosa
 Hok Kan (Ronald) Tsang
 Joseph Putko
 Phil Wyett
+Raul Infante-Sainz
 Ole Streicher
 Rahna Payyasseri Thanduparackal
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]