Re: [PATCH] Makefile: fix pipefail.

[Adrien 'neox' Bourmault]

Le samedi 13 janvier 2024 à 17:41 +0100, Denis 'GNUtoo' Carikli a
écrit :
> In the commit d68b4f8930dc47ca23c0d88347a8c33472a9b930 ("Makefile:
> Add
> logging.") I forgot to add the SHELL := $(shell which bash) line that
> is mentionned in the commit to the Makefile.
> 
> So now the Makefile targets are actually broken:
> $ make release
>     echo 'Makefile: running release target' >> make-1705163885.log
>     set -o pipefail ; ./build release src | tee -a make-
> 1705163885.log
>     /bin/sh: 1: set: Illegal option -o pipefail
>     make: *** [Makefile:59: release] Error 2
> 
> Since 'SHELL := bash' also works on PureOS 10 and Trisquel 10, I'll
> use that instead as it is more simple.
> 
> The path of bash is not hardcoded to respect users decisions to use
> the bash they want, and also to work better with non-FHS
> distributions.
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> 

Hi, thanks a lot. I acked this patch and pushed it to the gnuboot-next
branch.

Happy hacking!
-- 
Adrien Bourmault
Maintainer, GNU Boot project
Associate member, Free Software Foundation
GPG : 9AA8CDA0DC9C0604D26AE4A72974E1D5F25DFCC8

signature.asc
Description: This is a digitally signed message part