[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] website: docs: contribute: fix markdown link syntax
From: |
Denis 'GNUtoo' Carikli |
Subject: |
Re: [PATCH 1/2] website: docs: contribute: fix markdown link syntax |
Date: |
Mon, 20 Jan 2025 21:14:00 +0100 |
Hi,
On Sun, 19 Jan 2025 19:56:07 +0100
Alex via Gnuboot-patches <gnuboot-patches@gnu.org> wrote:
> -As for reporting what you tested, you can open a new bug or send a
> -mail to the [gnuboot](http://lists.gnu.org/mailman/listinfo/gnuboot)
> -or [Bug-gnuboot]
> -(https://lists.gnu.org/mailman/listinfo/bug-gnuboot) mailing list.
> +As for reporting what you tested, you can open a new bug or send a
> mail to +the
> [gnuboot](http://lists.gnu.org/mailman/listinfo/gnuboot) or
> +[Bug-gnuboot](https://lists.gnu.org/mailman/listinfo/bug-gnuboot) mailing
> +list.
[...]
Thanks a lot for the patches.
I've added the following to the commit message just in case it wasn't
clear:
> Without that fix, on the deployed GNU Boot website, the
> Bug-gnuboot link appears as "[Bug-gnuboot]
> (https://lists.gnu.org/mailman/listinfo/bug-gnuboot)" inside the
> HTML instead of appearing as a link (<a
> href="[...]">Bug-gnuboot</a>), and the link in "Technical
> contributions" has the same issue.
>
> The Savannah link was also made clickable along the way.
Just seeing problematic markdown code doesn't make the problem obvious
for me, so I added this explanation, but in another hand I'm not very
familiar with CommonMark details and/or the various markdown
implementations, so I'm not sure if adding the above is a good idea or
not, because if things are obvious for everybody else, this context can
be removed.
I also added the commit that broke the links.
Beside that the patch is OK for me, so if Adrien also agrees, the patch
can be merged and the website updated. I've pushed it in the
gnuboot-next branch until Adrien adds his ack.
Acked-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Denis.
pgpLT2bWXU0n7.pgp
Description: OpenPGP digital signature