[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gnugo-devel] final patch, first version
From: |
Gunnar Farneback |
Subject: |
Re: [gnugo-devel] final patch, first version |
Date: |
Sun, 08 Sep 2002 16:14:01 +0200 |
User-agent: |
EMH/1.14.1 SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.3 Emacs/20.7 (sparc-sun-solaris2.7) (with unibyte mode) |
Paul wrote:
> - removes sgf_output parameter from all decide_ functions (we have a
> global variable outfilename now).
Please undo this change and make sure that the decide_ functions don't
even build a tree unless an output file has been provided. Those trees
can become absurdly huge and we do want a way to avoid them when
needed.
> gmp mode should work properly with handicaps now (no changes, but
> there's no more sgfffile_open_file() and sgffile_close_file()).
Those calls were never directly related to the problem. What solved
the problem was the removal of the sgffile_put_stone() call from
sgffile_recordboard().
> Index: interface/play_gtp.c
> ===================================================================
> RCS file: /cvsroot/gnugo/gnugo/interface/play_gtp.c,v
> retrieving revision 1.86
> diff -u -r1.86 play_gtp.c
> --- interface/play_gtp.c 2 Sep 2002 14:19:22 -0000 1.86
> +++ interface/play_gtp.c 7 Sep 2002 13:50:25 -0000
> @@ -2792,7 +2792,7 @@
> gtp_start_sgftrace(char *s)
> {
> UNUSED(s);
> - begin_sgftreedump(>p_sgftree);
> + sgffile_begindump(>p_sgftree);
> count_variations = 1;
> return gtp_success("");
> }
> @@ -2820,7 +2820,7 @@
> if (nread < 1)
> return gtp_failure("missing filename");
>
> - end_sgftreedump(filename);
> + sgffile_enddump();
> count_variations = 0;
> return gtp_success("");
> }
>
So the user provided filename is discarded? That's not acceptable.
(And no, the -O filename doesn't suffice. It's possible to generate
multiple sgf files from within GTP mode.)
/Gunnar