Re: Family History access error in Overview + solution

[Karsten Hilbert]

Am Mon, Mar 17, 2025 at 09:53:59PM -0300 schrieb Maria Scappini:

> I got this error when trying to access Capt. Kirk's brother history from 
> History in
> Overview:
>
> type: <class 'NameError'>
> value: name 'FamilyHistoryWidgets' is not defined
>   File
> "/home/jessie/Desktop/GNUmed_ES/gnumed-client.1.8.19/Gnumed/wxpython/gmListWidgets.py",
> line 2246, in _on_list_item_activated
>     self.__activate_callback(event)
>   File 
> "/home/jessie/Desktop/GNUmed_ES/gnumed-client.1.8.19/Gnumed/wxpython/gmPatOverviewWidgets.py",
> line 814, in _on_history_item_activated
>     FamilyHistoryWidgets.manage_family_history(parent = self)
>     ^^^^^^^^^^^^^^^^^^^^
>
> Solved by adding "gm" before "FamilyHistoryWiedgets."(...)  on line 814 of the
> gmPatOverviewWidgets.py file, as attached.

Indeed. I have added this fix to the codebase.

> Is this the correct way to share this type of proposal of fixes? Should I 
> instead use
> git hub?

For small things such as this sending an email is fine.

If you happen to fix several things in several files the
preferred way is a pull request on github. That is not
mandatory, however.

Best,
Karsten
--
GPG  40BE 5B0E C98E 1713 AFA6  5BC0 3BEA AC80 7D4F C89B