[taler-exchange] branch master updated: point out duplication, fix hard-coded '2'

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

The following commit(s) were added to refs/heads/master by this push:
     new 81d3b454 point out duplication, fix hard-coded '2'
81d3b454 is described below

commit 81d3b454e177b3cbc68e99795a526958f6992be3
Author: Christian Grothoff <address@hidden>
AuthorDate: Fri Jan 17 20:50:39 2020 +0100

    point out duplication, fix hard-coded '2'
---
 src/include/taler_testing_lib.h    |  2 ++
 src/lib/testing_api_helpers_bank.c | 11 +++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/include/taler_testing_lib.h b/src/include/taler_testing_lib.h
index c5263550..f884cd99 100644
--- a/src/include/taler_testing_lib.h
+++ b/src/include/taler_testing_lib.h
@@ -276,6 +276,8 @@ struct TALER_TESTING_BankConfiguration
   /**
    * Base URL of the exchange's bank account. Basically
    * @e bank_url plus the exchange account.
+   *
+   * FIXME: remove? This duplicates exchange_auth.wire_gateway_url!
    */
   char *exchange_account_url;
 
diff --git a/src/lib/testing_api_helpers_bank.c 
b/src/lib/testing_api_helpers_bank.c
index 5bc08fbf..d6fac4bd 100644
--- a/src/lib/testing_api_helpers_bank.c
+++ b/src/lib/testing_api_helpers_bank.c
@@ -403,17 +403,19 @@ TALER_TESTING_prepare_fakebank (const char 
*config_filename,
     return GNUNET_SYSERR;
   }
   bc->exchange_auth.method = TALER_BANK_AUTH_NONE;
-  // FIXME: we should not hardcode exchange account number "2"
+
   GNUNET_asprintf (&bc->exchange_auth.wire_gateway_url,
-                   "http://localhost:%u/2/";,
-                   (unsigned int) fakebank_port);
+                   "http://localhost:%u/%s/";,
+                   (unsigned int) fakebank_port,
+                   EXCHANGE_ACCOUNT_NAME);
 
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Using fakebank %s on port %u\n",
               bc->exchange_auth.wire_gateway_url,
               (unsigned int) fakebank_port);
 
-  GNUNET_log (GNUNET_ERROR_TYPE_INFO, "Fakebank port from config: %u\n",
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+              "Fakebank port from config: %u\n",
               (unsigned int) fakebank_port);
 
   GNUNET_CONFIGURATION_destroy (cfg);
@@ -425,6 +427,7 @@ TALER_TESTING_prepare_fakebank (const char *config_filename,
     bc->bank_url = NULL;
     return GNUNET_SYSERR;
   }
+  /* FIXME: this duplicates bc->exchange_auth.wire_gateway_url */
   GNUNET_asprintf (&bc->exchange_account_url,
                    "http://localhost:%u/%s/";,
                    fakebank_port,

-- 
To stop receiving notification emails like this one, please contact
address@hidden.