[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnurl] 252/264: smtp: set auth correctly
From: |
gnunet |
Subject: |
[gnurl] 252/264: smtp: set auth correctly |
Date: |
Thu, 30 Apr 2020 16:09:15 +0200 |
This is an automated email from the git hooks/post-receive script.
nikita pushed a commit to branch master
in repository gnurl.
commit 446fb0518bd4525c679343dd88d75d13dd201be3
Author: Daniel Stenberg <address@hidden>
AuthorDate: Sat Apr 25 00:22:21 2020 +0200
smtp: set auth correctly
Regression since 7.69.0 and 68fb25fa3fcff.
The code wrongly assigned 'from' instead of 'auth' which probably was a
copy and paste mistake from other code, leading to that auth could
remain NULL and later cause an error to be returned.
Assisted-by: Eric Sauvageau
Fixes #5294
Closes #5295
---
lib/smtp.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/smtp.c b/lib/smtp.c
index 93e004d20..bf65f246f 100644
--- a/lib/smtp.c
+++ b/lib/smtp.c
@@ -625,8 +625,7 @@ static CURLcode smtp_perform_mail(struct connectdata *conn)
utf8 = TRUE;
if(host.name) {
- free(from);
- from = aprintf("<%s@%s>", address, host.name);
+ auth = aprintf("<%s@%s>", address, host.name);
Curl_free_idnconverted_hostname(&host);
}
@@ -636,8 +635,6 @@ static CURLcode smtp_perform_mail(struct connectdata *conn)
auth = aprintf("<%s>", address);
free(address);
- if(!from)
- return CURLE_OUT_OF_MEMORY;
}
else
/* Empty AUTH, RFC-2554, sect. 5 */
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [gnurl] 238/264: curl.h: update comment typo, (continued)
- [gnurl] 238/264: curl.h: update comment typo, gnunet, 2020/04/30
- [gnurl] 237/264: GnuTLS: Don't skip really long certificate fields, gnunet, 2020/04/30
- [gnurl] 239/264: RELEASE-NOTES: synced, gnunet, 2020/04/30
- [gnurl] 203/264: sockfilt: tidy variable naming and data structure in select_ws, gnunet, 2020/04/30
- [gnurl] 204/264: tests: run the sws server on "any port", gnunet, 2020/04/30
- [gnurl] 194/264: cmake: Avoid MSVC C4273 warnings in send/recv checks, gnunet, 2020/04/30
- [gnurl] 195/264: docs/MQTT: replace confusing 80 by 75, gnunet, 2020/04/30
- [gnurl] 193/264: KNOWN_BUGS: Add entry 'Blocking socket operations', gnunet, 2020/04/30
- [gnurl] 215/264: runtests: dummy init the ports variables to avoid warnings, gnunet, 2020/04/30
- [gnurl] 216/264: src: Remove C99 constructs to ensure C89 compliance, gnunet, 2020/04/30
- [gnurl] 252/264: smtp: set auth correctly,
gnunet <=
- [gnurl] 250/264: libssh: avoid options override by configuration files, gnunet, 2020/04/30
- [gnurl] 191/264: sockfilt: fix broken pipe on Windows to be ready in select_ws, gnunet, 2020/04/30
- [gnurl] 224/264: mqtt: improve the state machine, gnunet, 2020/04/30
- [gnurl] 219/264: add more alt-svc test coverage, gnunet, 2020/04/30
- [gnurl] 218/264: test1247: use http server to get the port number set, gnunet, 2020/04/30
- [gnurl] 246/264: tests: make runtests check that disabled tests exists, gnunet, 2020/04/30
- [gnurl] 200/264: mqttd: s/errno/SOCKERRNO, gnunet, 2020/04/30
- [gnurl] 201/264: appveyor: add Unicode winbuild jobs, gnunet, 2020/04/30
- [gnurl] 199/264: buildconf: use find -execdir instead, remove -print and the ares files, gnunet, 2020/04/30
- [gnurl] 197/264: copyright: bump the copyright year range, gnunet, 2020/04/30