[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[libeufin] branch master updated: Double submission of same PAIN.
From: |
gnunet |
Subject: |
[libeufin] branch master updated: Double submission of same PAIN. |
Date: |
Thu, 03 Sep 2020 11:39:08 +0200 |
This is an automated email from the git hooks/post-receive script.
ms pushed a commit to branch master
in repository libeufin.
The following commit(s) were added to refs/heads/master by this push:
new f5e1649 Double submission of same PAIN.
f5e1649 is described below
commit f5e1649daa2e8470babcc2d8188b8ffae0f09d1e
Author: MS <ms@taler.net>
AuthorDate: Mon Aug 3 13:51:35 2020 +0200
Double submission of same PAIN.
Nexus returns 500, after having gotten a
EBICS_PROCESSING_ERROR from the Sandbox.
---
integration-tests/test-ebics-double-payment-submission.py | 7 ++++---
nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsClient.kt | 4 +++-
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/integration-tests/test-ebics-double-payment-submission.py
b/integration-tests/test-ebics-double-payment-submission.py
index 3ab8ed3..de11155 100755
--- a/integration-tests/test-ebics-double-payment-submission.py
+++ b/integration-tests/test-ebics-double-payment-submission.py
@@ -43,8 +43,8 @@ def fail(msg):
exit(1)
-def assertResponse(response):
- if response.status_code != 200:
+def assertResponse(response, acceptedResponses=[200]):
+ if response.status_code not in acceptedResponses:
print("Test failed on URL: {}".format(response.url))
# stdout/stderr from both services is A LOT of text.
# Confusing to dump all that to console.
@@ -155,7 +155,8 @@ assertResponse(
f"http://localhost:5001/bank-accounts/{BANK_ACCOUNT_LABEL}/payment-initiations/{PREPARED_PAYMENT_UUID}/submit",
json=dict(),
headers=dict(Authorization=USER_AUTHORIZATION_HEADER),
- )
+ ),
+ [500]
)
print("Test passed!")
diff --git a/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsClient.kt
b/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsClient.kt
index 426c2c0..e45c21a 100644
--- a/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsClient.kt
+++ b/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsClient.kt
@@ -224,7 +224,9 @@ suspend fun doEbicsUploadTransaction(
EbicsReturnCode.EBICS_OK -> {
}
else -> {
- throw NexusError(HttpStatusCode.InternalServerError, "unexpected
return code")
+ throw NexusError(HttpStatusCode.InternalServerError,
+ "Unexpected EBICS return code: ${txResp.technicalReturnCode}"
+ )
}
}
}
--
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [libeufin] branch master updated: Double submission of same PAIN.,
gnunet <=