Re: [PATCH] Minor fix in NSWindowController

[Fred Kiefer]

Quentin Mathé wrote:
> I have done new tests with other applications today like Notebook,  Ink
> and ToolbarExample (which is document based). With the two last  ones,
> the result is a segmentation fault on a document window  close :-/. It's
> retain/release issue. Now I think that's the extra  'retain' I removed
> in NSWindowController is just covering another bug  (may be more). I
> would say it's probably related to - isReleasedWhenClosed value not
> properly ignored everywhere when  NSWindowController is used in
> NSDocument architecture context. What's  your take on this ?
> 

Most likely this segmentation fault was the reason I introduced the
retain call in the first place.
Now with the new explanation from Apple we need to change some code. I
would insist, that what ever you change it should not break existing
applications. Apart from that feel free to bring our code closer to what
should be done. From my point of view the whole code in
[NSWindowController _windowWillClose:] could go away, but I am not deep
enough into this any more.

Cheers
Fred