Re: gnustep-back font display broken on cairo

[Riccardo Mottola]

Hi Fred!

On 8/9/19 3:38 PM, Fred Kiefer wrote:
> Oops, I might have miscalculated the old value. It should be 33 not 17. And if 
> this doesn’t help either, try to revert all the changes in CairoFontInfo.m


if I set it to 33 everything seems to work fine, I did only a quick test 
though. I see no bad spacing in a couple of tests and apps and also no 
hangs.

Fonts look also "nicer" somehow, on my LCD screen.


If I set it to 17, I get a hang with the following when I "break"

#0  0xb74aff60 in objc_msg_lookup () from 
/usr/lib/i386-linux-gnu/libobjc.so.4
#1  0xb7bade95 in -[NSFont ascender] (self=0x8662ce0, _cmd=0xb7fb2148 
<_OBJC_SELECTOR_TABLE+328>) at NSFont.m:1110
#2  0xb7cf010a in -[GSHorizontalTypesetter layoutLineNewParagraph:] 
(self=0x8388738, _cmd=0xb7fb2220 <_OBJC_SELECTOR_TABLE+544>,
    newParagraph=1 '\001') at GSHorizontalTypesetter.m:737
#3  0xb7cf14c6 in -[GSHorizontalTypesetter 
layoutGlyphsInLayoutManager:inTextContainer:startingAtGlyphIndex:previousLineFragmentRect:nextGlyphIndex:numberOfLineFragments:] 
(self=0x8388738, _cmd=0xb7fb00c0 <_OBJC_SELECTOR_TABLE+352>, 
layoutManager=0x8712ea8,
    textContainer=0x8713050, glyphIndex=0, previousLineFragRect=..., 
nextGlyphIndex=0xbfffe5b8, howMany=<optimized out>)
    at GSHorizontalTypesetter.m:1308
#4  0xb7ceb084 in -[GSLayoutManager(LayoutHelpers) 
_doLayoutToContainer:] (self=0x8712ea8, _cmd=0xb7fb00a8 
<_OBJC_SELECTOR_TABLE+328>,
    cindex=0) at GSLayoutManager.m:1957
#5  0xb7ce86e0 in -[GSLayoutManager(LayoutHelpers) _doLayout] 
(self=0x8712ea8, _cmd=0xb7f24340 <_OBJC_SELECTOR_TABLE+800>)
    at GSLayoutManager.m:1845
#6  0xb7bd4dc6 in -[NSLayoutManager(layout) 
_insertionPointRectForCharacterIndex:textContainer:] (self=0x8712ea8,
    _cmd=0xb7f24418 <_OBJC_SELECTOR_TABLE+1016>, cindex=413, 
textContainer=0xbfffe6c8) at NSLayoutManager.m:860
#7  0xb7bd2dbf in -[NSLayoutManager(layout) 
insertionPointRectForCharacterIndex:inTextContainer:] (self=0x8712ea8,
    _cmd=0xb7f7cf90 <_OBJC_SELECTOR_TABLE+2064>, cindex=413, 
textContainer=0x8713050) at NSLayoutManager.m:977
#8  0xb7c83724 in -[NSTextView(leftovers) 
updateInsertionPointStateAndRestartTimer:] (self=0x87126c8,
    _cmd=0xb7f7c928 <_OBJC_SELECTOR_TABLE+424>, restartFlag=1 '\001') 
at NSTextView.m:4215
#9  0xb7c7ec58 in -[NSTextView(leftovers) 
setSelectedRange:affinity:stillSelecting:] (self=0x87126c8,
    _cmd=0xb7f7d120 <_OBJC_SELECTOR_TABLE+2464>, charRange=..., 
affinity=0, stillSelectingFlag=0 '\000') at NSTextView.m:3778
#10 0xb7c76e9e in -[NSTextView(leftovers) setSelectedRange:] 
(self=0x87126c8, _cmd=0xb7f24688 <_OBJC_SELECTOR_TABLE+1640>,
    charRange=...) at NSTextView.m:3624
#11 0xb7bda0b3 in -[NSLayoutManager 
textStorage:edited:range:changeInLength:invalidatedRange:] (self=0x8712ea8,
    _cmd=0xb7f75f48 <_OBJC_SELECTOR_TABLE+200>, aTextStorage=0x8712c28, 
mask=3, range=..., lengthChange=<optimized out>,
    invalidatedRange=...) at NSLayoutManager.m:2959
#12 0xb7c718f1 in -[NSTextStorage processEditing] (self=0x8712c28, 
_cmd=0xb7f75f00 <_OBJC_SELECTOR_TABLE+128>) at NSTextStorage.m:266
#13 0xb7c70c2d in -[NSTextStorage endEditing] (self=0x8712c28, 
_cmd=0xb79c54a8 <_OBJC_SELECTOR_TABLE+456>) at NSTextStorage.m:133
#14 0xb75c6326 in -[NSMutableAttributedString 
replaceCharactersInRange:withAttributedString:] (self=0x8712c28,
    _cmd=0xb79c54b0 <_OBJC_SELECTOR_TABLE+464>, aRange=..., 
attributedString=0x85cb838) at NSAttributedString.m:1084
#15 0xb75c64a1 in -[NSMutableAttributedString setAttributedString:] 
(self=0x8712c28, _cmd=0x8050448 <_OBJC_SELECTOR_TABLE+1000>,
    attributedString=0x85cb838) at NSAttributedString.m:1103
#16 0x08049cab in -[Document windowControllerDidLoadNib:] 
(self=0x8661700, _cmd=0xb7f967a0 <_OBJC_SELECTOR_TABLE+288>,
    aController=0x82e3d18) at Document.m:193
#17 0xb7cbd342 in -[NSWindowController window] (self=0x82e3d18, 
_cmd=0xb7f96730 <_OBJC_SELECTOR_TABLE+176>) at NSWindowController.m:314
#18 0xb7cbd719 in -[NSWindowController showWindow:] (self=0x82e3d18, 
_cmd=0xb7f02c68 <_OBJC_SELECTOR_TABLE+520>, sender=0x8661700)
    at NSWindowController.m:395


I don't know if this could actually be an issue?


If remove the setting the "default" value causes the issues we are 
talking about. Text looks "thinner" and slightly irregular for certain 
fonts.


Riccardo


PS: I will be away for a couple of days, I'll have a Mac with a GNUstep 
VM, but I still need to check if the issue reproduces there.