Re: missing file

[Simon Josefsson]

Nikos Mavrogiannopoulos <address@hidden> writes:

> Simon Josefsson wrote:
>> Nikos, did you forget to commit some file?
>> 
>> cryptodev.c:29:30: error: crypto/cryptodev.h: No such file or directory
>
> It was including this file unconditionally. Now it should be ok (only
> included if --enable-cryptodev is specified). If you have a cpu with
> crypto accelerator that is supported by linux (via and some amd geode
> cpus have), and you use cryptodev you should get quite a difference. For
> some reason I get big difference by using the kernel aes implementation.
>
> address@hidden:~/cvs/gnutls/src$ ./benchmark
> Checking AES (8kb payload)... Transferred 58720 kb in 1.40 secs:
> 41883.21 kbyte/sec
> Checking AES (16kb payload)... Transferred 117440 kb in 2.71 secs:
> 43384.01 kbyte/sec
> Checking AES (32kb payload)... Transferred 234881 kb in 5.37 secs:
> 43780.25 kbyte/sec
>
> [after cryptodev module loaded]
> address@hidden:~/cvs/gnutls/src$ ./benchmark
> Checking AES (8kb payload)... Transferred 58720 kb in 0.49 secs:
> 120328.39 kbyte/sec
> Checking AES (16kb payload)... Transferred 117440 kb in 0.82 secs:
> 142871.67 kbyte/sec
> Checking AES (32kb payload)... Transferred 234881 kb in 1.64 secs:
> 143045.69 kbyte/sec

Nice!

> PS. I cannot seem to get how configure.ac works now. I have added a
> cryptodev test in configure.ac (global), but the ENABLE_CRYPTODEV
> definition is only in root config.h and lib/config.h does not have it
> (gnutls_int.h doesn't include the root one). How can I add a check like
> that?

There is a lib/configure.ac too.  Put all configure checks that are
specific to lib/ stuff into that configure.ac.  If there are things that
are common between lib/ and libextra/, put those checks into
lib/m4/hooks.m4.

/Simon