[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: doc bug for gnutls_priority_init
From: |
Nikos Mavrogiannopoulos |
Subject: |
Re: doc bug for gnutls_priority_init |
Date: |
Fri, 02 Apr 2010 11:01:52 +0200 |
User-agent: |
Thunderbird 2.0.0.24 (X11/20100317) |
Paul Aurich wrote:
> And Paul Aurich spoke on 03/31/2010 07:53 PM, saying:
>> The documentation for gnutls_priority_init reads, in part:
>>
>> The priorities option allows you to specify a semi-colon
>> separated list of the cipher priorities to enable.
>>
>> However, the examples (and source code) all show *colon*-separated strings.
>> I'm trying to use an environment variable that would let users override
>> priorities on a per-host basis, so I'd like to do something like the
>> following:
>
> On a slightly related note (in that it has to do with the same function),
> it looks like gnutls_priority_init() doesn't free+NULL the
> gnutls_priority_t on error, where various other init functions do
> (gnutls_init, gnutls_pkcs12_init, gnutls_x509_crl_init, and maybe more).
>
> Should it do so, or should it be noted in the documentation that callers
> must call gnutls_priority_deinit on errors (which I'm going to do in this
> code to avoid leaks, but would ideally eventually become a nop)?
You are correct on both cases. I've commited a fix. Indeed a colon is
required to separate the fields.
regards,
Nikos