[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[sr #107538] Patch: "warning: cast to pointer from integer of different
From: |
Simon Josefsson |
Subject: |
[sr #107538] Patch: "warning: cast to pointer from integer of different size" |
Date: |
Thu, 25 Nov 2010 17:55:09 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101101 IceCat/3.6.12 (like Firefox/3.6.12) |
Follow-up Comment #2, sr #107538 (project gnutls):
Re pointer-from-integer: why ssize_t? Wouldn't 'unsigned long' be better?
Otherwise I agree with this patch.
Re gnutls_handshake.patch: this looks wrong for two reasons, first we don't
use assert () because it would crash an application (instead we should return
errors), and secondly, I don't think there is an error to end up in the
default case. So there is no reason for even gnutls_assert there, is there?
/Simon
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/support/?107538>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/