[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: New Defects reported by Coverity Scan for gpsd-gitlab
|
From: |
Gary E. Miller |
|
Subject: |
Re: New Defects reported by Coverity Scan for gpsd-gitlab |
|
Date: |
Tue, 26 Jan 2021 10:33:59 -0800 |
Yo Greg!
On Tue, 26 Jan 2021 08:49:15 -0500
Greg Troxel <gdt@lexort.com> wrote:
> "Gary E. Miller" <gem@rellim.com> writes:
>
> >>>> CID 316451: (UNINIT)
> >>>> Using uninitialized value "g.fix.speed" when calling
> >>>> "wprintw".
> > 242 (void)wprintw(navsolwin, "%6.2fm/s %5.1fo %6.2fm/s",
> > 243 g.fix.speed, g.fix.track, g.fix.climb);
>
> I tried to just read the code, and I see g is on the stack, and a
> bunch of things are set from the provided data, and I can't find
> where speed is ever set. So this does look like an uninitialized
> read.
That was my take as well.
> How and where do you think g.fix.speed will have been set?
Git log shows it used to be setup. Until I finish the xml excision
I'm not gonna look hard at this.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
gem@rellim.com Tel:+1 541 382 8588
Veritas liberabit vos. -- Quid est veritas?
"If you can't measure it, you can't improve it." - Lord Kelvin
pgpY2OhKwmazE.pgp
Description: OpenPGP digital signature