groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 03/05: src/roff/troff/input.cpp: Delete old comment.


From: G. Branden Robinson
Subject: [groff] 03/05: src/roff/troff/input.cpp: Delete old comment.
Date: Sun, 3 Jan 2021 17:46:51 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit cde6fd1559b02dc76258f1094852bb2a193e1cc9
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sun Jan 3 22:55:32 2021 +1100

    src/roff/troff/input.cpp: Delete old comment.
    
    * src/roff/troff/input.cpp (init_registers): Delete comment from 1992.
      C++ maintains separate name spaces for structure tags and type names
      as C does (the main difference being that C++ permits the creation of
      user-defined name spaces which are then partitioned much as C name
      spaces are).  It seems that a version of g++ that was old in 1992
      unified the name space for structure tags and type names.  Support for
      any such compiler would have ceased long ago.
    
    This comment has tripped me up more than once, so I'm getting rid of it.
---
 ChangeLog                | 11 +++++++++++
 src/roff/troff/input.cpp |  1 -
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 1253798..31240ad 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2021-01-03  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * src/roff/troff/input.cpp (init_registers): Delete comment from
+       1992.  C++ maintains separate name spaces for structure tags and
+       type names as C does (the main difference being that C++ permits
+       the creation of user-defined name spaces which are then
+       partitioned much as C name spaces are).  It seems that a version
+       of g++ that was old in 1992 unified the name space for structure
+       tags and type names.  Support for any such compiler would have
+       ceased long ago.
+
 2020-12-25  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * doc/doc.am (.texi.dvi): Call texi2dvi with FORCE_SOURCE_DATE=1
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index a436028..cb20e00 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -8168,7 +8168,6 @@ static void init_registers()
   time_t
 #endif /* not LONG_FOR_TIME_T */
     t = current_time();
-  // Use struct here to work around misfeature in old versions of g++.
   struct tm *tt = localtime(&t);
   set_number_reg("seconds", int(tt->tm_sec));
   set_number_reg("minutes", int(tt->tm_min));



reply via email to

[Prev in Thread] Current Thread [Next in Thread]