groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 05/15: m4/groff.m4: Drop redundant messages.


From: G. Branden Robinson
Subject: [groff] 05/15: m4/groff.m4: Drop redundant messages.
Date: Fri, 3 Jun 2022 05:04:51 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit c3435d4bb864bc10d430e1ff74782fa2d7f484b9
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Wed Jun 1 13:16:14 2022 -0500

    m4/groff.m4: Drop redundant messages.
    
    * m4/groff.m4 (GROFF_X11, GROFF_UCHARDET): Drop redundant messages
      (which are easily overlooked amid the torrent of "checking" output
      anyway).  Discovery failures of X11 and the unchardet library are
      already parts of the configuration report at or near the end of
      output.
---
 ChangeLog   |  8 ++++++++
 m4/groff.m4 | 15 +++++----------
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e4cff697..c40a8135 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2022-06-01  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * m4/groff.m4 (GROFF_X11, GROFF_UCHARDET): Drop redundant
+       messages (which are easily overlooked amid the torrent of
+       "checking" output anyway).  Discovery failures of X11 and the
+       unchardet library are already parts of the configuration report
+       at or near the end of output.
+
 2022-06-01  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * m4/groff.m4 (GROFF_PNMTOPS_NOSETPAGE): Partially revert change
diff --git a/m4/groff.m4 b/m4/groff.m4
index 002f0a47..561a1721 100644
--- a/m4/groff.m4
+++ b/m4/groff.m4
@@ -1536,13 +1536,11 @@ AC_DEFUN([GROFF_X11],
      LIBS=$OLDLIBS
    fi
 
-   if test "$groff_no_x" = yes; then
-     AC_MSG_NOTICE([gxditview and xtotroff won't be built])
-   else
-     XDEVDIRS="font/devX75 font/devX75-12 font/devX100 font/devX100-12"
-     XPROGDIRS="src/devices/xditview src/utils/xtotroff"
-     XLIBDIRS="src/libs/libxutil"
-   fi
+  if ! test "$groff_no_x" = yes; then
+    XDEVDIRS="font/devX75 font/devX75-12 font/devX100 font/devX100-12"
+    XPROGDIRS="src/devices/xditview src/utils/xtotroff"
+    XLIBDIRS="src/libs/libxutil"
+  fi
 
    AC_SUBST([XDEVDIRS])
    AC_SUBST([XPROGDIRS])
@@ -1704,9 +1702,6 @@ file encoding [=auto|no|yes]]))
           if test "$with_uchardet" = yes
           then
             AC_MSG_FAILURE([could not find uchardet library])
-          else
-            AC_MSG_WARN([uchardet library not found; preconv will be \
-less functional])
           fi
           groff_have_uchardet=no])],
       [groff_have_uchardet=no])



reply via email to

[Prev in Thread] Current Thread [Next in Thread]