groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 16/16: [troff]: Fix code style nits (static functions).


From: G. Branden Robinson
Subject: [groff] 16/16: [troff]: Fix code style nits (static functions).
Date: Wed, 10 Jan 2024 23:55:05 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit 688c4fb37425d81200018392c12d0d9a4ad30987
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Wed Jan 10 22:35:49 2024 -0600

    [troff]: Fix code style nits (static functions).
    
    * src/roff/troff/input.cpp (device_request, device_macro_request)
      (output_request): Declare functions `static` since they do not require
      external linkage.
---
 ChangeLog                | 8 ++++++++
 src/roff/troff/input.cpp | 6 +++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0137b4536..a055185f6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2024-01-10  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       [troff]: Fix code style nits.
+
+       * src/roff/troff/input.cpp (device_request)
+       (device_macro_request, output_request): Declare functions
+       `static` since they do not require external linkage.
+
 2024-01-09  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        [troff]: Add unit test for `\X` (device control) escape
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 7455d6077..8f8df4f92 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -5676,7 +5676,7 @@ static node *do_special()
   return new special_node(mac);
 }
 
-void device_request()
+static void device_request()
 {
   // We can't use `has_arg()` here because we want to read in copy mode.
   int c;
@@ -5708,7 +5708,7 @@ void device_request()
   tok.next();
 }
 
-void device_macro_request()
+static void device_macro_request()
 {
   symbol s = get_name(true /* required */);
   if (!(s.is_null() || s.is_empty())) {
@@ -5723,7 +5723,7 @@ void device_macro_request()
   skip_line();
 }
 
-void output_request()
+static void output_request()
 {
   // We can't use `has_arg()` here because we want to read in copy mode.
   int c;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]