groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 01/07: doc/doc.am: Fix absent directory creation.


From: G. Branden Robinson
Subject: [groff] 01/07: doc/doc.am: Fix absent directory creation.
Date: Wed, 31 Jan 2024 06:25:08 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit 081b89a1dad341b7dc91b98b75ae8f57ec9ea5e5
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Wed Jan 31 00:52:15 2024 -0600

    doc/doc.am: Fix absent directory creation.
    
    * doc/doc.am ($(DOC_GNU_EPS)): Create "doc" destination directory before
      trying to create a file in it.  This bug has been latent (for
      out-of-tree builds) for ages, but has seemingly seldom or never
      arisen.  It seems that even in parallel builds, one of the many other
      "doc" targets that _did_ use the `MKDIR_P` make(1) macro nearly always
      won the race.  (In my experience, in builds from Git, the generated
      forms of our Texinfo manual could be relied upon to do this because
      they were near the root of the dependency tree; other groff targets
      tend not to depend on them.)  Anyway, fixed now.
---
 ChangeLog  | 13 +++++++++++++
 doc/doc.am |  3 ++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index f816790f9..c0d0f71ae 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2024-01-31  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * doc/doc.am ($(DOC_GNU_EPS)): Create "doc" destination
+       directory before trying to create a file in it.  This bug has
+       been latent (for out-of-tree builds) for ages, but has seemingly
+       seldom or never arisen.  It seems that even in parallel builds,
+       one of the many other "doc" targets that _did_ use the `MKDIR_P`
+       make(1) macro nearly always won the race.  (In my experience, in
+       builds from Git, the generated forms of our Texinfo manual could
+       be relied upon to do this because they were near the root of the
+       dependency tree; other groff targets tend not to depend on
+       them.)  Anyway, fixed now.
+
 2024-01-31  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * doc/doc.am (DOCFILES_INST): Ship "GMPfront.t" in the
diff --git a/doc/doc.am b/doc/doc.am
index f9842420b..bc31a99ba 100644
--- a/doc/doc.am
+++ b/doc/doc.am
@@ -736,7 +736,8 @@ uninstall-txt:
 # available if xpmtoppm is (see macro "GROFF_PROG_XPMTOPPM").
 EXTRA_DIST += $(DOC_GNU_EPS) doc/gnu.xpm
 $(DOC_GNU_EPS): doc/gnu.xpm
-       $(AM_V_GEN)if test "$(XPMTOPPM)" != found; then \
+       $(AM_V_GEN)$(MKDIR_P) `dirname $@` \
+       && if test "$(XPMTOPPM)" != found; then \
          echo "program 'xpmtoppm' is missing; can't generate $@" >&2; \
          exit 1; \
        fi; \



reply via email to

[Prev in Thread] Current Thread [Next in Thread]