Re: [Groff] [groff] 05/05: * */Makefile.*: Path quoting fixes, whitespace, formatting.

[Keith Marshall]

On 03/04/14 06:59, Werner LEMBERG wrote:
> wl pushed a commit to branch master
> in repository groff.
> 
> commit 1b8b2a7b019846b6340611e5c562f5b6b3f5ba74
> Author: Steffen Nurpmeso <address@hidden>
> Date:   Thu Apr 3 07:58:48 2014 +0200
> 
>     * */Makefile.*: Path quoting fixes, whitespace, formatting.
>     
>     Remove many quotes (and introduce a few as additional guards) since
>     groff's build system is generally not set up to properly handle
>     paths that need quoting.
>     
> ...
>     
> diff --git a/Makefile.comm b/Makefile.comm
> index 6bcb2e8..89bbc25 100644
> --- a/Makefile.comm
> +++ b/Makefile.comm
>     
> ...
>     
> @@ -118,11 +118,11 @@ uninstall_sub:
>       -for f in $(MOSTLYCLEANADD); do \
>         rm -f $(DESTDIR)$(fontsubdir)/$$f; \
>       done
> -     -d="$(DESTDIR)$(fontsubdir)/enc"; \
> -       if test -d "$$d"; then rmdir "$$d"; fi
> -     -d="$(DESTDIR)$(fontsubdir)/map"; \
> -       if test -d "$$d"; then rmdir "$$d"; fi
> -     -d="$(DESTDIR)$(fontsubdir)/util"; \
> -       if test -d "$$d"; then rmdir "$$d"; fi
> -     -d="$(DESTDIR)$(fontsubdir)"; \
> -       if test -d "$$d"; then rmdir "$$d"; fi
> +     -d=$(DESTDIR)$(fontsubdir)/enc; \
> +       if test -d $$d; then rmdir $$d; fi
> +     -d=$(DESTDIR)$(fontsubdir)/map; \
> +       if test -d $$d; then rmdir $$d; fi
> +     -d=$(DESTDIR)$(fontsubdir)/util; \
> +       if test -d $$d; then rmdir $$d; fi
> +     -d=$(DESTDIR)$(fontsubdir); \
> +       if test -d $$d; then rmdir $$d; fi

Will removal of the quotes here not lead to failure, if the user has
configured with (say) `--prefix="C:/Program Files/groff"'?  (Remember
that $(fontsubdir) is a make macro, and will now be expanded unquoted,
*before* evaluating the shell variable assignment).

-- 
Regards,
Keith.