Re: [bug #44289] [PATCH] nroff script -E option

[Ingo Schwarze]

Hi,

following Dave's good work of identifying bugtracker tickets that
contain patches, i started looking through those.  Here is one
that is very easy to fix, and i think nothing would be wrong with
fixing it right away, before release.  I see no risk doing so.

I'm looking for an OK to commit.

Yours,
  Ingo


Ingo Schwarze wrote on Tue, Oct 13, 2020 at 04:38:47PM -0400:

>   <https://savannah.gnu.org/bugs/?44289>
> 
>                 Category:                    None => Device - others        
>                   Status:                    None => In Progress            
>              Assigned to:                    None => schwarze               
>          Planned Release:                    None => 1.23                   
> 
>     _______________________________________________________
> 
> Follow-up Comment #1:
> 
> I agree with the intention.
> I cannot see any good reason why nroff(1) should
> pass through -w and -W but not -E.
> 
> However, the patch #33113 is wrong and must not be committed.
> It discards all standard error output, not just error messages.
> 
> Writing a better patch is trivial, see [below].


commit 29acfe7cbca55a959345c09eb4c83f9076f945bf
Author: Ingo Schwarze <schwarze@openbsd.org>
Date:   Tue Oct 13 22:25:55 2020 +0200

    Pass through -E option from nroff(1) to groff(1).
    
    * src/roff/nroff/nroff.sh: Implement passthrough.
    * src/roff/nroff/nroff.1.man: Document passthrough.
    
    Mini-feature suggested by <Osamu dot Sayama at oracle dot com>
    in https://savannah.gnu.org/bugs/?44289,
    but implemented in a better way.

diff --git a/ChangeLog b/ChangeLog
index d80975bc..3d6b8d84 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2020-10-13 Ingo Schwarze <schwarze@openbsd.org>
+
+       Pass through -E option from nroff(1) to groff(1).
+
+       * src/roff/nroff/nroff.sh: Implement passthrough.
+       * src/roff/nroff/nroff.1.man: Document passthrough.
+
+       Mini-feature suggested by <Osamu dot Sayama at oracle dot com>
+       in https://savannah.gnu.org/bugs/?44289,
+       but implemented in a better way.
+
 2020-10-12 Bertrand Garrigues <bertrand.garrigues@laposte.net>
 
        Update 'gnulib' submodule.
diff --git a/src/roff/nroff/nroff.1.man b/src/roff/nroff/nroff.1.man
index 2cd38b0c..1ad2e43f 100644
--- a/src/roff/nroff/nroff.1.man
+++ b/src/roff/nroff/nroff.1.man
@@ -148,6 +148,7 @@ permitted between an option and its argument.
 The
 .BR \-C ,
 .BR \-d ,
+.BR \-E ,
 .BR \-i ,
 .BR \-m ,
 .BR \-M ,
diff --git a/src/roff/nroff/nroff.sh b/src/roff/nroff/nroff.sh
index 86deaf40..e30d63e0 100644
--- a/src/roff/nroff/nroff.sh
+++ b/src/roff/nroff/nroff.sh
@@ -75,7 +75,7 @@ do
     -[dmMnoPrTwW])
       echo "$prog: option '$1' requires an argument" >&2
       exit 1 ;;
-    -[CipStU] | -[dMmrnoPwW]*)
+    -[CEipStU] | -[dMmrnoPwW]*)
       opts="$opts $1" ;;
     -T*)
       Topt=$1 ;;