Re: [groff] 15/39: [grog]: Drop relic code and comments.

[G. Branden Robinson]

At 2022-10-30T21:08:08-0500, G. Branden Robinson wrote:
> I'd prefer to audit the script as you describe than to restore this
> arcane feature to it; I had to find out about it the hard way.

Here's a patch.

commit 4acdddb9d4db1c20d7cc4f5f4f0ce2908e20c271 (HEAD -> master)
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sun Oct 30 21:21:54 2022 -0500

    [grog]: Restore trailing newlines to output.

    * src/utils/grog/grog.pl (fail, warn, construct_command, version):
      Restore trailing newlines to `print`ed output.  They went missing when
      I removed the assignment of the output record separator in commit
      6f2e367836, 24 October.  Thanks to Dave Kemper for catching this.

diff --git a/src/utils/grog/grog.pl b/src/utils/grog/grog.pl
index 85fc9130f..f61275638 100644
--- a/src/utils/grog/grog.pl
+++ b/src/utils/grog/grog.pl
@@ -79,14 +79,14 @@ my $have_any_valid_arguments = 0;

 sub fail {
   my $text = shift;
-  print STDERR "$program_name: error: $text";
+  print STDERR "$program_name: error: $text\n";
   $had_processing_problem = 1;
 }


 sub warn {
   my $text = shift;
-  print STDERR "$program_name: warning: $text";
+  print STDERR "$program_name: warning: $text\n";
 }


@@ -658,11 +658,11 @@ sub construct_command {
   #########
   # execute the 'groff' command here with option '--run'
   if ( $do_run ) { # with --run
-    print STDERR "@command";
+    print STDERR "@command\n";
     my $cmd = join ' ', @command;
     system($cmd);
   } else {
-    print "@command";
+    print "@command\n";
   }
 } # construct_command()

@@ -686,7 +686,7 @@ sub usage {


 sub version {
-  print "GNU $program_name (groff) $groff_version";
+  print "GNU $program_name (groff) $groff_version\n";
   exit 0;
 } # version()


Regards,
Branden

signature.asc
Description: PGP signature