Re: [groff] 19/40: [devpdf]: Tweak generation of "download" file.

[Deri]

On Saturday, 12 November 2022 20:26:08 GMT Deri wrote:
> On Saturday, 12 November 2022 19:43:37 GMT G. Branden Robinson wrote:
> > gbranden pushed a commit to branch master
> > in repository groff.
> > 
> > commit 6838addc2924c45874e7f3f8ebaf46716c4c3613
> > Author: G. Branden Robinson <g.branden.robinson@gmail.com>
> > AuthorDate: Wed Nov 9 08:24:52 2022 -0600
> > 
> >     [devpdf]: Tweak generation of "download" file.
> >     
> >     * font/devpdf/devpdf.am (font/devpdf/download): Improve
> >     
> >       comprehensibility of comments in generated "download" file.  Stop
> >       bracketing path element separator with spaces.
> > 
> > ---
> > 
> >  ChangeLog             | 6 ++++++
> >  font/devpdf/devpdf.am | 5 +++--
> >  2 files changed, 9 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ChangeLog b/ChangeLog
> > index a94b9d03c..8bc759fda 100644
> > --- a/ChangeLog
> > +++ b/ChangeLog
> > @@ -1,3 +1,9 @@
> > +2022-11-09  G. Branden Robinson <g.branden.robinson@gmail.com>
> > +
> > +   * font/devpdf/devpdf.am (font/devpdf/download): Improve
> > +   comprehensibility of comments in generated "download" file.
> > +   Stop bracketing path element separator with spaces.
> > +
> > 
> >  2022-11-09  G. Branden Robinson <g.branden.robinson@gmail.com>
> >  
> >     * font/devpdf/util/BuildFoundries.pl (LoadFoundry): Stop
> > 
> > diff --git a/font/devpdf/devpdf.am b/font/devpdf/devpdf.am
> > index 663774f01..ac5257698 100644
> > --- a/font/devpdf/devpdf.am
> > +++ b/font/devpdf/devpdf.am
> > @@ -110,11 +110,12 @@ font/devpdf/download: $(devpdffontmapdata)
> > font/devpdf/DESC \ font/devpdf/Foundry font/devpdf/enc/text.enc \
> > 
> >    font/devpdf/util/BuildFoundries
> >     
> >     $(AM_V_GEN)$(MKDIR_P) $(top_builddir)/font/devpdf \
> > 
> > -   && echo "# foundry      ps-name psfile" >$@.tmp \
> > +   && echo "# foundry      ps-font-name    ps-font-file" >$@.tmp \
> > +   && echo "# A blank foundry is the default." >>$@.tmp \
> > 
> >     &&
> > 
> > PATH="$(abs_top_builddir)$(GROFF_PATH_SEPARATOR)$(abs_top_builddir)/build-
> > a
> > ux$(GROFF_PATH_SEPARATOR)$(PATH)" \
> > $(abs_top_builddir)/font/devpdf/util/BuildFoundries \
> > 
> >            --strict $(abs_top_builddir)/font/devpdf \
> > 
> > -          '$(abs_top_srcdir)/font/devps : $(abs_top_builddir)/font/
> 
> devps' \
> 
> > +          '$(abs_top_srcdir)/font/devps:$(abs_top_builddir)/font/devps'
> 
> \
> 
> >            >>$@.tmp \
> >     
> >     && mv $@.tmp $@
> > 
> > _______________________________________________
> > Groff-commit mailing list
> > Groff-commit@gnu.org
> > https://lists.gnu.org/mailman/listinfo/groff-commit
> 
> Sorry, this needs a revert too.

Parts of this is fine, (removing the space separators), but I did not quite 
understand the changes to devpdf.am, and by this time I was a little peeved. 
:-)

Cheers 

Deri