Re: GRUB2: *BSD and more patch

[Yoshinori K. Okuji]

On Sunday 21 March 2004 02:17, Sergey Matveychuk wrote:
> @@ -716,9 +773,6 @@ pupa_util_biosdisk_get_pupa_dev (const c
>        return 0;
>      }
>    
> -  if (! S_ISBLK (st.st_mode))
> -    return make_device_name (drive, -1, -1);
> - 

This part is not good. The problem here is that we want to support 
installing GRUB into a normal file as well as a device file.

So what I said to you was wrong. The check about a block device is 
sometimes very important. In FreeBSD, what is the right way to 
distinguish a device file from a normal file?

> +#ifdef HAVE_MEMALIGN
>    p = memalign (align, size);
> +#else
> +  p = malloc(size);
> +#endif

I don't agree on this one. Please implement memalign correctly. It's not 
so difficult. Probably it can be like this (not tested):

p = malloc((size + align - 1) & ~(align - 1));
if (! p)
  return 0;
return (p + align - 1) & ~(align - 1);

It might be possible to find a better implementation, if you see glibc.

BTW, I confirmed that you haven't assigned your copyright on GRUB to the 
FSF yet. For a GNU project, it is a custom to assign your copyright to 
the FSF, so that the FSF can fight instead of you in a court when 
someone claims that our software is illegal. Also, this step of a 
copyright assignment makes sure that your contribution will be free in 
freedom forever. So, would you like to sign a copyright assignment for 
GRUB? If you need more information, don't hesitate to ask me. We can 
talk privately if you want.

Okuji