Re: [ppc patch] setjmp/longjmp

[Marco Gerards]

Hollis Blanchard <address@hidden> writes:

> I've implemented setjmp and longjmp for PowerPC. Annoyingly, because PPC
> still has no module support, files are compiled with -DGRUB_UTIL=1, and
> that causes include/grub/setjmp.h to redefine both functions. I guess
> that means we used to link in the libc setjmp/longjmp (which then failed
> miserably when one tried to run them).

Nice.  This evening I will try to fix that -DGRUB_UTIL thing and test
this code of yours.

>   * normal/powerpc/setjmp.S (grub_setjmp): New function.
>   (grub_longjmp): Likewise.

You can better say:

* normal/powerpc/setjmp.S: New file.

When you make a new file and you did not move old code there saying it
is a new file is sufficient.

> Index: conf/powerpc-ieee1275.rmk
...
> +     normal/powerpc/setjmp.S \

I don't see this change in your changelog entry.

Thanks,
Marco