Re: [PATCH] normal/cmdline.c : history contains empty lines

[Yoshinori K. Okuji]

On Tuesday 14 December 2004 08:08, Vincent Pelletier wrote:
> 2004-12-13 Vincent Pelletier <address@hidden>
> * grub_history_get : doesn't add empty lines, exits if called with
> NULL argument
> * grub_cmdline_get : command is added to history after user hit
> "return", when pressing "down" arrow when on the most recent item in
> history an empty line is shown

I agree that empty lines should not be added into the history, but I 
don't think it is a good idea to show an empty line when you go down 
the history. Because I really like to have compatibility with BASH.

I don't know how the current implementation behaves very well, but it 
should work in the same way as GRUB legacy. It should be like this:

PROMPT        HISTORY
grub>         []
foo[RET]
grub>         ["foo"]
bar[RET]
grub>         ["foo", "bar"]
[RET]
grub>         ["foo", "bar"]
[C-p]
grub> bar     ["foo", "bar"]
[C-n]
grub>         ["foo", "bar"]
[C-p]
grub> bar     ["foo", "bar"]
baz[RET]
grub>         ["foo", "bar", "barbaz"]

Okuji