Re: [ppc patch] grub-mkimage and module loading

[Marco Gerards]

Hollis Blanchard <address@hidden> writes:

> I am in favor of option 2. This approach could also be used for the
> i386 port, but I guess there are other reasons we need to overwrite
> fixed-location variables there, so maybe it wouldn't simplify
> much. (I'm looking at the VARIABLE() macros in kern/i386/pc/startup.S)
> So it would also be easy to move the existing grub_load_modules() into
> arch-specific code, and use something like the above function for the
> PPC port.

I completely agree.  Before the modules there should be a header and
it can and IMHO it should be something that is portable.  I can't come
up with a reason why such header would make things harder instead of
easier.

It would be nice if we can get rid of `grub_get_end_addr'.  The best
thing we can do is renaming it to `grub_get_dl_modules_adrr' or
something like that.  It should be moved to a machine specific place.
After doing that you can use that new function, parse the header and
initialize the modules.

Thanks,
Marco