Re: [ppc] fix and improve grub-mkimage

[Marco Gerards]

Hollis Blanchard <address@hidden> writes:

> PPC grub-mkimage is broken in CVS, as MODULE_BASE was renamed to
> GRUB_IEEE1275_MODULE_BASE. This patch fixes the build break.

Whoops. :)

> In addition, this patch improves the CHRP NOTE segment support.
> Currently grub-mkimage expects to find a pre-built file named "note", but
> that's not a good solution (and the build system does not create this
> file). Instead, we can easily create the note data at runtime.

Sounds nice to me!

>
> -Hollis
>
> 2005-01-08  Hollis Blanchard  <address@hidden>
>
>       * util/powerpc/ieee1275/grub-mkimage.c: Include <string.h>.
>       (note_path): Remove variable.
>       (GRUB_IEEE1275_NOTE_NAME): New constant.
>       (GRUB_IEEE1275_NOTE_TYPE): Likewise.

Please say "New macro.".

>       (grub_ieee1275_note): New structure.
>       (load_note): Remove `dir' argument. All callers updated. Remove
>       `note_img' and `path'. Do note load a file from `note_path'.
>       Initialize a struct grub_ieee1275_note and write that to `out'.
>       Use GRUB_IEEE1275_MODULE_BASE instead of MODULE_BASE.

Please use two spaces after the ".".

> +/* See the CHRP binding to IEEE1275, "Client Program Format".  */
> +struct grub_ieee1275_note {

Please move the "{" to the next line, just like you do for functions:

struct grub_ieee1275_note
  {
    int foo;
    ...
  };


If you fixed all this, you can commit the patch.

Thanks,
Marco