Re: [PATCH] new ELF64 patch

[Hollis Blanchard]

On Jul 16, 2005, at 6:54 PM, Ruslan Nikolaev wrote:
> Ok patch for x86_64 ELF64 support was rewritten.
>
> diff -urN old/multiboot.c new/multiboot.c
> --- old/multiboot.c     2005-07-17 02:50:11.978394408 +0400
> +++ new/multiboot.c     2005-07-17 02:49:41.069093336 +0400
> @@ -89,7 +89,14 @@
>    struct grub_multiboot_header *header;
>    grub_ssize_t len;
>    int i;
> -  Elf32_Ehdr *ehdr;
> +  union {
> +    Elf32_Ehdr *ehdr32;
> +    Elf64_Ehdr *ehdr64;
> +  } hdr;
> +  union {
> +    Elf32_Phdr *phdr32;
> +    Elf64_Phdr *phdr64;
> +  } seg;

I don't like this. I would prefer having grub_rescue_cmd_multiboot() 
call two functions: grub_load_elf32() and grub_load_elf64():

grub_load_elf32(Elf32_Ehdr *header)
{
        if (header->e_ident[EI_CLASS] != ELFCLASS32)
                return error;

        /* load segments */
        ...
}

-Hollis