Re: Patch for boot message

[Robert Millan]

On Sun, Aug 12, 2007 at 11:47:24AM -0700, Mischa Spiegelmock wrote:
> Robert Millan wrote:
> >On Fri, Aug 10, 2007 at 11:18:55PM -0700, Mischa Spiegelmock wrote:
> >  
> >>I got sick of grub saying "The highlighted entry will be booted 
> >>automatically in 1 seconds."
> >>
> >>Here's a patch:
> >>
> >>Index: normal/menu.c
> >>===================================================================
> >>RCS file: /sources/grub/grub2/normal/menu.c,v
> >>retrieving revision 1.18
> >>diff -r1.18 menu.c
> >>331,332c331,332
> >><    The highlighted entry will be booted automatically in %d seconds.    
> >>",
> >><                      timeout);
> >>---
> >>    
> >>>   The highlighted entry will be booted automatically in %d 
> >>>      
> >>second%c     ",
> >>    
> >>>                     timeout, (timeout == 1 ? ' ' : 's'));
> >>>      
> >
> >This breaks l10n, and also adds a bogus ' ' (although that's a minor 
> >issue).
> >
> >The SI symbol for second is 's'.  Why not using that instead?
> >
> >  
> Well whatever, I was just trying to fix the currently broken behavior. 
> As for adding the "bogus" ' ', that's keeping in line with the comment 
> on the line before:
> 
>          /* NOTE: Do not remove the trailing space characters.
>             They are required to clear the line.  */

Ah, right.  I see.

> I just tried to do the least invasive patch that would keep the amount 
> of characters constant.

I fixed it to use "s".  Thanks for the correction

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)