Re: [PATCH] fix serial console on LinuxBIOS

[Marco Gerards]

Robert Millan <address@hidden> writes:

> This patch fixes serial console on LinuxBIOS.
>
> I'd appreciate comments (specially on the <grub/machine/machine.h> addition).
>
> -- 
> Robert Millan
>
> <GPLv2> I know my rights; I want my phone call!
> <DRM> What use is a phone call, if you are unable to speak?
> (as seen on /.)
>

No header ;)

>       * include/grub/i386/efi/machine.h: New file.
>       * include/grub/i386/linuxbios/machine.h: Likewise.
>       * include/grub/i386/pc/machine.h: Likewise.
>       * include/grub/powerpc/ieee1275/machine.h: Likewise.
>       * include/grub/sparc64/ieee1275/machine.h: Likewise.
>
>       * term/i386/pc/serial.c: Include <grub/machine/machine.h>.
>       (serial_hw_io_addr): New variable.
>       (serial_hw_get_port): Obtain port address from `serial_hw_io_addr'
>       instead of `(unsigned short *) 0x400'.

This seems fine to me.  What is your intended use for machine.h?  More
than just this?

Perhaps we can even use autoconf to define this in config.h?  That
would be better I think.

--
Marco