Re: grub2 ChangeLog term/i386/pc/serial.c

[Robert Millan]

On Fri, Nov 09, 2007 at 04:26:02PM +0100, Marco Gerards wrote:
> >
> > I always thought the Right Way to do this would be implement it in GCC,
> > so that you can do things like:
> >
> >   __some_magic__(PORT_ADDR) |= 0x80;
> >
> > which is much more beatufil than either of:
> >
> >   outb (PORT_ADDR, inb (PORT_ADDR) | 0x80);
> >
> >   outb (inb (PORT_ADDR) | 0x80, PORT_ADDR);
> >
> > don't you think?
> >
> > (now if someone is bored and takes my suggestion to gcc-patches, that'd make
> > my day...)
> 
> That's possible in C++ using operator overloading AFAIK.

Ah, right.  Maybe we could switch to building with g++ just to get this
feature ;-)

> Did this commit fix serial support for LB?

No, it fixed a bug affecting all platforms (i.e. both of them ;-)).

For serial.mod to work on LB, we need the other patch (the machine.h one).

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)