Re: [PATCH] mkdevicemap for Cygwin

[Christian Franke]

Robert Millan wrote:
> On Tue, Nov 13, 2007 at 09:42:26PM +0100, Christian Franke wrote:
>   
> > +#elif defined(__CYGWIN__)
> > +  /* Cygwin */
> > +  sprintf (name, "/dev/fd%d", unit);
> >     
>
> Cygwin has /dev now?  :-)
>
>   

At least since 2003.


> > +#ifndef __CYGWIN__
> >  static void
> >  get_ide_disk_name (char *name, int unit)
> >  {
> > @@ -213,6 +217,7 @@ get_ide_disk_name (char *name, int unit)
> >    *name = 0;
> >  #endif
> >  }
> > +#endif /* __CYGWIN__ */
> >     
>
>   
> > [...]
> >     
>
>   
> > +#ifndef __CYGWIN__    
> >    /* IDE disks.  */
> >    for (i = 0; i < 8; i++)
> >      {
> > @@ -431,6 +440,7 @@ make_device_map (const char *device_map,
> >           num_hd++;
> >         }
> >      }
> > +#endif /* __CYGWIN__ */
> >     
>
> Is the generic case (`*name = 0', then print that) good enough?
>
>   


No, it did not work because check_device() returned 1 ("exists") on 
(*name == 0). This results in 8 bogus "(hd N)\t\n" lines and wrong N for 
the real devices.

Yes, it would work now, because the patch also fixes this bug :-)

Christian