Re: [PATCH] buffered file read

[Marco Gerards]

Bean <address@hidden> writes:

> On Fri, Aug 1, 2008 at 3:18 AM, Marco Gerards <address@hidden> wrote:
>> Hi Bean,
>>
>> Bean <address@hidden> writes:
>>
>>> I have added a buffer length parameter to grub_buffile_open:
>>>
>>> grub_file_t grub_buffile_open (const char *name, int size);
>>>
>>> size < 0: Load the whole file.
>>> size = 0: Use default buffer size (8192 bytes)
>>> size > 0: Custom buffer size = size
>>>
>>> The upper limit is 1m, if size > 1m, we set it to 1m.
>>>
>>> 2008-07-28  Bean  <address@hidden>
>>>
>>>       * conf/common.rmk (pkglib_MODULES): Add bufio.mod.
>>>       (bufio_mod_SOURCES): New macro.
>>>       (bufio_mod_CFLAGS): Likewise.
>>>       (bufio_mod_LDFLAGS): Likewise.
>>>
>>>       * include/grub/bufio.h: New file.
>>>
>>>       * io/bufio.c: Likewise.
>>>
>>>       * video/png.c (grub_video_reader_png): Use grub_buffile_open to open
>>>       file.
>>>
>>>       * video/jpeg.c (grub_video_reader_jpeg): Likewise.
>>>
>>>       * video/tga.c (grub_video_reader_tga): Likewise.
>>>
>>>       * font/manager.c (add_font): Likewise.
>>
>> Please mention it when you include <include/grub/bufio.h>.  The same
>> for when you remove <include/grub/file.h>.
>>
>> Otherwise it seems good for inclusion :-)
>
> Hi,
>
> Oh, how the changelog would be like ?

Specifically or generally?  Generally something like:

         * fs/foo.c: Include <grub/bar.h>.
         (baz): New function.
....

--
Marco