[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] update configure.ac to autoconf 2.61
From: |
Felix Zielcke |
Subject: |
Re: [PATCH] update configure.ac to autoconf 2.61 |
Date: |
Sun, 21 Sep 2008 19:39:04 +0200 |
Well, commited.
Am Donnerstag, den 04.09.2008, 09:45 +0200 schrieb Felix Zielcke:
> Am Mittwoch, den 03.09.2008, 19:43 -0400 schrieb Pavel Roskin:
> >
> > I don't see any old stuff being removed. I don't see any justification
> > for any of the changes. The new code is longer and less readable. I
> > don't think AC_TRY_COMPILE is a big problem yet. It's not like it won't
> > produce a valid test.
>
> http://www.gnu.org/software/autoconf/manual/autoconf.html#Autoconf-Macro-Index
>
> AC_TRY_COMPILE is listed as `Obsolete Macro'.
>
> I attached now even a diff with autoconf 2.62 which I won't commit, but
> maybe you or someone else is interested.
> Changelog says AC_GNU_SOURCE has been deprecated, though they're
> currently no plans to remove it.
>
> Currently it's not really needed but things get easily forgotten, even I
> myself forgot a patch from me ..
> We don't need to discuss running `autoupdate' in ./autogen.sh this is
> really bad.
> The Debian Build System has such a feature too but ftp-masters' reject
> packages which uses it by default.
>
> You only need to run autoconf -Wall then you see.
> Ok they're not shown by default, but I don't like to have obsolte
> deprecated stuff if it can be easily avoided like in this case.
>
> > In any case, please try to avoid extra long lines where it can be easily
> > avoided.
>
> I hope the intention is now right, Emacs had a problem with it.
>
> > Okuji wrote that he uses Autoconf 2.59, so it would be nice to check
> > that your changes would still work with that version.
>
> Luckly it's still avaible in Debian oldstable (sarge)
> newest CentOS 5.2 even still has autoconf 2.59
> Changes are the same as with 2.61 so 2.59 seems to be fine.
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel