grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] make partition active


From: phcoder
Subject: Re: [PATCH] make partition active
Date: Sun, 01 Mar 2009 22:20:23 +0100
User-agent: Thunderbird 2.0.0.19 (X11/20090105)

Hello
It's also possible to write a wrapper
parttool hd0,1 boot+

Which chooses the correct tool and launches it (a tool can be easily
registered as a pair of partition style name and a function). In this case
we wouldn't even need separate command for different partition style. We
have however to find a way to list all available flags in

help parttool

Hi,

The patch looks fine to me, except for perhaps the name. activate
doesn't seems to suggest its function. Frankly, makeactive doesn't
make much sense as well, but at least it's already widely used in grub
legacy, old user could easily guess its function by name.

Then we could use parttool syntax. Then parttype can be implemented like
grub> parttool hd0,1 type=7
makeactive like:
grub> parttool hd0,1 boot+
And it can even be done by one command
grub> parttool hd0,1 boot+ type=7

Thank you for your attention to my patches



--

Regards
Vladimir 'phcoder' Serbinenko




reply via email to

[Prev in Thread] Current Thread [Next in Thread]