grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: can't compile r220 because of setjmp.S


From: Vladimir 'phcoder' Serbinenko
Subject: Re: can't compile r220 because of setjmp.S
Date: Sat, 16 May 2009 19:27:59 +0200

2009/5/16 Javier Martín <address@hidden>:
> El sáb, 16-05-2009 a las 19:22 +0200, Felix Zielcke escribió:
>> Am Samstag, den 16.05.2009, 18:52 +0200 schrieb Felix Zielcke:
>>
>> > As said on IRC, it seems like the -m32 was missing there, even though it
>> > should be set through the COMMON_CSFLAGS in i386-pc.rmk.
>> > But that did the trick in i386.rmk:
>> >
>> > -setjmp_mod_CFLAGS = $(COMMON_CFLAGS)
>> > +setjmp_mod_ASFLAGS = $(COMMON_ASFLAGS)
>>
>> Commited this change as Acked-by Vladimir on IRC.
> You only changed it in i386. Given that a .S file is always "compiled"
> by the assembler, shouldn't the change be applied to all other platforms
> too?
>
True. I didn't see it was the same mistake in other arches as well. Nice catch
> --
> -- Lazy, Oblivious, Recurrent Disaster -- Habbit
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko




reply via email to

[Prev in Thread] Current Thread [Next in Thread]